Skip to content

Fix temporary map files not being deleted in production mode #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2017
Merged

Fix temporary map files not being deleted in production mode #170

merged 1 commit into from
Oct 2, 2017

Conversation

Lyrkan
Copy link
Collaborator

@Lyrkan Lyrkan commented Sep 29, 2017

This PR fixes <entry>.js.map files not being deleted after calling addStyleEntry(...) and enableSourceMaps(true) in production mode.

weaverryan
weaverryan approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice catch!

@Lyrkan Lyrkan merged commit 929a253 into symfony:master Oct 2, 2017
@Lyrkan Lyrkan deleted the fix-temporary-map branch October 2, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lyrkan @weaverryan