[Live] Doc'ing how to set values via Js, select sync bug & auto-setting data-model values #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
sync-models-on-load
branch
from
4c10242 to
3c18e92
Compare
weaverryan
changed the title
weaverryan
force-pushed
the
sync-models-on-load
branch
from
3c18e92 to
d950435
Compare
weaverryan
changed the title
… sync empty select fields 2 features/bugs mixed together: 1) Auto-setting "value" of data-model elements from component data 2) Fixing bug where select element without a blank doesn't sync value back to component Fixing a few model-related rendering bugs A) Only re-set values after re-render for models that have fully changed, not just fields that have been modified (but show value may not be synced back to the value store yet) B) When setting the value property on an input, skip any models that we know are in an unsynced state (i.e. we know they have a field that has changed, but the value hasn't been set onto the value store yet)
weaverryan
force-pushed
the
sync-models-on-load
branch
from
fd50438 to
af084ba
Compare
weaverryan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does 3 unrelated things to close #469 and #473
NOTE: BUILT ON TOP OF #466.
A) [X] Documents how to change a "model" field via JavaScript
B) [X] Fixes a problem where a
selectelement is rendered without anemptyoption, and so the component data isn't aware of the pre-selected option.C) [X] Automatically set the
valueof adata-modelfield - #473.Cheers!