Skip to content

[Autocomplete] Not destroyed on disconnect() #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

[Autocomplete] Not destroyed on disconnect() #367

merged 1 commit into from
Jun 23, 2022

Conversation

mpiot
Copy link
Contributor

@mpiot mpiot commented Jun 23, 2022

Q A
Bug fix? yes
New feature? no
Tickets Fix #366
License MIT

Call the destroy() method from TomSelect on disconnect event of the Controller. (https://tom-select.js.org/docs/api/)

@weaverryan
Copy link
Member

Good catch on this - thank you Mathieu!

@weaverryan weaverryan merged commit 0699d44 into symfony:2.x Jun 23, 2022
@tgalopin
Copy link
Contributor

I built the dist file for this in #368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Autocomplete] Not destroyed on disconnect()
3 participants
@mpiot @weaverryan @tgalopin