Skip to content

Conversation

@bernard-ng
Copy link
Contributor

@bernard-ng bernard-ng commented Oct 17, 2025

Q A
Bug fix? no
New feature? yes
Deprecations? no
Documentation? no
License MIT

Add support for Item component, A versatile component that you can use to display any content.
ref : https://ui.shadcn.com/docs/components/item

@bernard-ng bernard-ng requested a review from Kocal as a code owner October 17, 2025 18:56
@carsonbot carsonbot added Toolkit Status: Needs Review Needs to be reviewed labels Oct 17, 2025
@bernard-ng bernard-ng force-pushed the bernard-ng/toolkit-shadcn-item branch 5 times, most recently from d65c127 to 25b6cf7 Compare October 17, 2025 19:39
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the contribution :)

Could you rebase on latest 2.x which contains #3154, and add necessary {# @prop #} and {# @block #} tags please?
That would be appreciated.

Thanks!

@bernard-ng bernard-ng force-pushed the bernard-ng/toolkit-shadcn-item branch from 25b6cf7 to bde6354 Compare November 6, 2025 18:24
@bernard-ng bernard-ng requested a review from Kocal November 6, 2025 18:31
@Kocal Kocal force-pushed the bernard-ng/toolkit-shadcn-item branch from 23e5a51 to 1d65267 Compare November 8, 2025 07:49
@Kocal Kocal force-pushed the bernard-ng/toolkit-shadcn-item branch from 1d65267 to ec90133 Compare November 8, 2025 07:50
@Kocal
Copy link
Member

Kocal commented Nov 8, 2025

I did some minor fixes, the components were not able to be rendered correctly due to html_cva() wrong usage, the syntax between the deprecated cva() from UX and html_cva() from Twig Extra is different:
image

But it looks good, thanks @bernard-ng :)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 8, 2025
@Kocal
Copy link
Member

Kocal commented Nov 8, 2025

Thank you @bernard-ng.

@Kocal Kocal merged commit 028ff98 into symfony:2.x Nov 8, 2025
28 of 30 checks passed
@bernard-ng
Copy link
Contributor Author

I did some minor fixes, the components were not able to be rendered correctly due to html_cva() wrong usage, the syntax between the deprecated cva() from UX and html_cva() from Twig Extra is different: image

But it looks good, thanks @bernard-ng :)

How do I get this preview ?

@Kocal
Copy link
Member

Kocal commented Nov 8, 2025

Oops, sorry, it looks like some contribution steps are missing. 😅

For the moment, kits examples are rendered on the Symfony UX website. Located in ux.symfony.com folder from this repo, you can find installation & usage steps here.

The website should be accessible at http://127.0.0.1:9044, then you will find the page "Toolkit", click on the "Shadcn" UI Kit, and here you will see all the existing components and their examples.

I agree that's not the best DX, but that's the best we could have for the moment.

Let me know if you need more help.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Reviewed Has been reviewed by a maintainer Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants