[LiveComponent] 500 errors with MethodNotAllowedException on dev after 2.28 upgrade

[jmsche]

Hello,

After upgrading UX Live component from 2.27 to 2.28.1 (but the bug also happens on 2.28.0), I'm getting the following error when I toggle some checkboxes that are marked as #[LiveProp(writable: true)] in the related Live component.

After having a little look at the merged PRs between the releases, I guess this is the one making it fail now: #2673

Here's the stack trace:

Symfony\Component\Routing\Exception\MethodNotAllowedException:

  at vendor/symfony/routing/Matcher/Dumper/CompiledUrlMatcherTrait.php:42
  at Symfony\Component\Routing\Matcher\CompiledUrlMatcher->match()
     (vendor/symfony/routing/Router.php:177)
  at Symfony\Component\Routing\Router->match()
     (vendor/symfony/ux-live-component/src/Util/UrlFactory.php:63)
  at Symfony\UX\LiveComponent\Util\UrlFactory->createPath()
     (vendor/symfony/ux-live-component/src/Util/UrlFactory.php:45)
  at Symfony\UX\LiveComponent\Util\UrlFactory->createFromPreviousAndProps()
     (vendor/symfony/ux-live-component/src/EventListener/LiveUrlSubscriber.php:48)
  at Symfony\UX\LiveComponent\EventListener\LiveUrlSubscriber->onKernelResponse()
     (vendor/symfony/event-dispatcher/Debug/WrappedListener.php:115)
  at Symfony\Component\EventDispatcher\Debug\WrappedListener->__invoke()
     (vendor/symfony/event-dispatcher/EventDispatcher.php:206)
  at Symfony\Component\EventDispatcher\EventDispatcher->callListeners()
     (vendor/symfony/event-dispatcher/EventDispatcher.php:56)
  at Symfony\Component\EventDispatcher\EventDispatcher->dispatch()
     (vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php:126)
  at Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->dispatch()
     (vendor/symfony/http-kernel/HttpKernel.php:216)
  at Symfony\Component\HttpKernel\HttpKernel->filterResponse()
     (vendor/symfony/http-kernel/HttpKernel.php:204)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw()
     (vendor/symfony/http-kernel/HttpKernel.php:76)
  at Symfony\Component\HttpKernel\HttpKernel->handle()
     (vendor/symfony/http-kernel/Kernel.php:182)
  at Symfony\Component\HttpKernel\Kernel->handle()
     (vendor/symfony/runtime/Runner/Symfony/HttpKernelRunner.php:35)
  at Symfony\Component\Runtime\Runner\Symfony\HttpKernelRunner->run()
     (vendor/autoload_runtime.php:29)
  at require_once('/.../vendor/autoload_runtime.php')
     (public/index.php:7)               

I'll try to create a reproducer soon.

[jmsche]

Here is the reproducer: https://github.com/jmsche/symfony-ux-issue-2960

• composer install
• symfony serve
• browse, check one of the checkboxes and... enjoy the bug 😅

[zacharylund]

You can fix this by changing #[Route('', name: 'app_default_index', methods: ['GET'])] to #[Route('', name: 'app_default_index', methods: ['GET', 'POST'])]

#2673 adds a X-Live-Url header that gets parsed by the routing component using the context of the current request (which is a POST to /_components/Test). Since app_default_index only accepts GET, it throws MethodNotAllowedException.

I think

ux/src/LiveComponent/src/Util/UrlFactory.php

Line 46 in 1f90d60

} catch (ResourceNotFoundException|MissingMandatoryParametersException) {

should either catch Symfony\Component\Routing\Exception\ExceptionInterface or additionally catch MethodNotAllowedException.

[smnandre]

What a perfect repro @jmsche thank you very much.

@zacharylund your solution seems to fix it i've just opened a PR.

Could you also test the previous commit @jmsche to see ?

I'm thinking we might need to update query in these scenarios and we won't with the single MethodNotAllowException fix..

cc @Kocal @kbond

[kbond]

2.28.2 released