Skip to content

Be consistent how we open XML dom #15249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2021
Merged

Be consistent how we open XML dom #15249

merged 1 commit into from
Apr 17, 2021

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Apr 16, 2021

Im not sure if we want to merge this. I just notice that we are using 4 different ways to open XML config.

If this is merged, I'll make a similar PR to re remaining examples in 5.2 (if any)

@Nyholm Nyholm requested a review from xabbuh as a code owner April 16, 2021 17:37
@carsonbot carsonbot added this to the 4.4 milestone Apr 16, 2021
javiereguiluz
javiereguiluz approved these changes Apr 17, 2021
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past we've made many similar changes to make something look the same across the entire docs. So, I'm voting in favor of doing this.

@OskarStark OskarStark mentioned this pull request Apr 17, 2021
Open
@javiereguiluz
Copy link
Member

Merged! Thanks Tobias!

@javiereguiluz javiereguiluz merged commit add69ed into symfony:4.4 Apr 17, 2021
@Nyholm
Copy link
Member Author

Nyholm commented Apr 17, 2021

Thank you for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@wouterj wouterj wouterj approved these changes

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Nyholm @javiereguiluz @wouterj @OskarStark @carsonbot