[FORM] Modify make:form to allow non-entities #301
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this modification the make:form command allowed passing a fully specified classname. It would generate a form with the correct bound class, but not read the fields. This also affects DTOs. This modification makes our lives easier by reading all fields of the bound class.
weaverryan
reviewed
Oct 23, 2018
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Nice improvement! And in such little code! Minor comments
src/Util/ClassDetails.php
Outdated
| $this->fullClassName = $fullClassName; | ||
| } | ||
|
|
||
| public function getProperties():? array |
Member
There was a problem hiding this comment.
Make this private and move to the bottom. At least right now, we don't need this to be public.
src/Util/ClassDetails.php
Outdated
| return $propertiesList; | ||
| } | ||
|
|
||
| public function getFormFields() |
src/Util/ClassDetails.php
Outdated
|
|
||
| namespace Symfony\Bundle\MakerBundle\Util; | ||
|
|
||
| use Symfony\Bundle\MakerBundle\Str; |
Make method private, Mark class as internal. Add DocComment to public method. Remove copied use statement.
Member
|
Thank you @ckrack! This is an obvious, but wonderful improvement. Great work! |
This was referenced Jul 3, 2020
weaverryan
added a commit
that referenced
this pull request
Jul 8, 2020
This PR was merged into the 1.0-dev branch. Discussion ---------- Docs: improve make:form helper Add information about the second argument (bound-class). Give hints on using the bound-class with classes other than entities. Improves on #301 and fixes #477 Commits ------- 6a9b1c9 docs: improve make:form helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this modification the make:form command allowed passing a fully specified classname.
It would generate a form with the correct bound class, but not read the fields.
It generated a form with one "field_name" field instead of something more useful.
This also affects DTOs.
This modification makes our lives easier by reading all fields of the bound class, except the id field.