Fix crud controller template #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2018 15:52
…hod parameter in controller template
Member
|
Very well-explained and an excellent patch! Thank you @thlbaut! |
weaverryan
added a commit
that referenced
this pull request
Oct 13, 2018
This PR was squashed before being merged into the 1.0-dev branch (closes #286). Discussion ---------- Fix crud controller template There is a mistake in crud controller template : Example (`src/Resources/skeleton/crud/controller/Controller.tpl.php` - line 35) : `return $this->render('<?= $route_name ?>/index.html.twig', ['<?= $entity_twig_var_plural ?>' => $<?= $entity_var_plural ?>]);` With an entity with following path :` Entity/Foo/BarBar.php` , `$route_name` will be equal to `foo_bar_bar` and does not correspond with the `index.html.twig` path (should be `foo/bar_bar`). This pull request fix this by adding the `$templatesPath` var, used to create twig templates, for the controller generation. :) Commits ------- f77a843 Rename template_var with templates_path (plural) 86d24f3 Create new template_path var and replace route_name var in render method parameter in controller template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a mistake in crud controller template :
Example (
src/Resources/skeleton/crud/controller/Controller.tpl.php- line 35) :return $this->render('<?= $route_name ?>/index.html.twig', ['<?= $entity_twig_var_plural ?>' => $<?= $entity_var_plural ?>]);With an entity with following path :
Entity/Foo/BarBar.php,$route_namewill be equal tofoo_bar_barand does not correspond with theindex.html.twigpath (should befoo/bar_bar).This pull request fix this by adding the
$templatesPathvar, used to create twig templates, for the controller generation.:)