[Voter] use ENTITY_ATTR instead of ATTR #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit longer, but this is much more explicite. This, is much easier to find all usage in a code base because the term is now unique
javiereguiluz
approved these changes
Oct 3, 2018
Member
javiereguiluz
left a comment
javiereguiluz
left a comment
There was a problem hiding this comment.
I like this. Let's be more explicit!
Member
|
Great idea! I like this much better |
weaverryan
added a commit
that referenced
this pull request
Oct 4, 2018
This PR was merged into the 1.0-dev branch. Discussion ---------- [Voter] use ENTITY_ATTR instead of ATTR This is a bit longer, but this is much more explicite. This is much easier to find all usage in a code base because the term is now unique Commits ------- 5405fc9 [Voter] use ENTITY_ATTR instead of ATTR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit longer, but this is much more explicite.
This is much easier to find all usage in a code base because the term is now unique