Add --no-template option for make:controller command #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codedmonkey
reviewed
Oct 1, 2018
src/Maker/MakeController.php
Outdated
| $command | ||
| ->setDescription('Creates a new controller class') | ||
| ->addArgument('controller-class', InputArgument::OPTIONAL, sprintf('Choose a name for your controller class (e.g. <fg=yellow>%sController</>)', Str::asClassName(Str::getRandomTerm()))) | ||
| ->addOption('--no-template', '-n', InputOption::VALUE_OPTIONAL) |
Contributor
There was a problem hiding this comment.
I think you mean InputOption::VALUE_NONE
Member
|
Hey @welcoMattic! In general, I want to be careful about adding customizations like this. But, this one seems reasonable. It looks like some of the existing controller tests broke. Can you check those out? I'm not sure what's going on - I'd try to run those test cases locally if you can. Cheers! |
Member
Author
|
Yes, existing tests broke. It seems to be because of If you can run those tests locally to help, that would be nice 😉 Thanks |
Member
|
Hey! Would you mind running the tests locally? I’m happy to review or debug (especially if the test suite doesn’t has any issues running on your machine), but I’d prefer you to finish this feature if you’d like it :) |
Member
Author
|
Hi @weaverryan! I just ran tests locally with Output
If I well understand, PHPUnit runs another PHPUnit to test generated code? I guess failure is in this sub-PHPUnit test suite |
Member
Author
|
Tests are green 🎉 The error was my shortcut of Feel free to merge if it is ok for you. |
Member
|
Sorry for the delay, but this was an excellent PR - very clean. Thank you @welcoMattic! |
weaverryan
added a commit
that referenced
this pull request
Dec 13, 2018
…lcoMattic) This PR was squashed before being merged into the 1.0-dev branch (closes #280). Discussion ---------- Add --no-template option for make:controller command I had several times the case in which I did not necessarily need a template when I generated a controller. So I'm trying to add an option `--no-template` to force avoid template generation. I think that I will need help on tests writing ;) Commits ------- 99680bc Fix tests (passed on local env) d6ec857 Fix internal project tests 052734c Try to fix tests 860d340 WIP Add --no-template option for make:controller command
Member
Author
|
No worries @weaverryan! Thank you for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had several times the case in which I did not necessarily need a template when I generated a controller. So I'm trying to add an option
--no-templateto force avoid template generation.I think that I will need help on tests writing ;)