Fix self-referencing entity associations #278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
requested changes
Oct 1, 2018
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Thanks for taking on this old bug! Great work with the code & test - just a few minor comments :)
src/Maker/MakeEntity.php
Outdated
| $newFieldName = $newField->getOwningProperty(); | ||
| $otherManipulatorFilename = $this->getPathOfClass($newField->getInverseClass()); | ||
| $otherManipulator = $this->createClassManipulator($otherManipulatorFilename, $io, $overwrite); | ||
| if ($newField->getInverseClass() !== $newField->getOwningClass()) { |
Member
There was a problem hiding this comment.
Could we use some $newField->isSelfReferencingMethod() here?
src/Util/ClassSourceManipulator.php
Outdated
| private function addCollectionRelation(BaseCollectionRelation $relation) | ||
| { | ||
| $typeHint = $this->addUseStatementIfNecessary($relation->getTargetClassName()); | ||
| $typeHint = !$relation->isSelfReferencing() ? $this->addUseStatementIfNecessary($relation->getTargetClassName()) : 'self'; |
Member
There was a problem hiding this comment.
Hmm, maybe reverse this - I think the ! is a bit confusing:
$typeHint = $relation->isSelfReferencing() ? 'self' : $this->addUseStatementIfNecessary($relation->getTargetClassName());
tests/Maker/FunctionalTest.php
Outdated
| // do you want to generate an inverse relation? (default to yes) | ||
| '', | ||
| // field name on opposite side | ||
| 'wards', |
Member
There was a problem hiding this comment.
This word isn't commonly used in English. Using dependents might be better (A parent/guardian refers to their children as "dependents")
Member
|
Thank you @codedmonkey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes faulty generation of entities with self-referencing associations #166. It looks like changes for the owning entity were overwritten by the changes for the inversed entity.