Fixing bad empty line when source file uses tabs #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
fix-empty-line
branch
from
4a94051 to
9f95fcd
Compare
weaverryan
added a commit
that referenced
this pull request
Aug 7, 2018
This PR was merged into the 1.0-dev branch. Discussion ---------- Fixing bad empty line when source file uses tabs Woo! Fixes #170 PHP-Parser is responsible for determining indentation for new code. When tabs are used, it sees this as 1 indent, and uses 1 space to indent. This had two side-effects: 1) My original `str_replace` code was not smart enough to handle that. Easy fix using regex 2) In general, any new code (e.g. getter method) is indented with 1 space. Commits ------- 9f95fcd Fixing bad empty line when used with tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Woo! Fixes #170
PHP-Parser is responsible for determining indentation for new code. When tabs are used, it sees this as 1 indent, and uses 1 space to indent. This had two side-effects:
str_replacecode was not smart enough to handle that. Easy fix using regex