Don't use :contains in the functional test tpl #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
reviewed
Jul 16, 2018
|
|
||
| $this->assertSame(200, $client->getResponse()->getStatusCode()); | ||
| $this->assertSame(1, $crawler->filter('h1:contains("Hello World")')->count()); | ||
| $this->assertCount(1, $crawler->filterXPath('//h1:[contains(text(), "Hello World")]')); |
Member
There was a problem hiding this comment.
What about
$this->assertContains('Hello World', $crawler->filter('h1'));
Member
There was a problem hiding this comment.
should be this though:
$this->assertContains('Hello World', $crawler->filter('h1')->text());And this assumes that it is the only h1 on the page btw (or at least the first one), otherwise the test would fail
Member
There was a problem hiding this comment.
You are right ;)
But anyway, this is boiler plate code, and it should be updated...
So I'm totally 👍 with stof's proposal
Member
|
I updated the selector to the simpler version, recommended by Stof, but still without the :contains. Thanks @dunglas! |
weaverryan
added a commit
that referenced
this pull request
Aug 6, 2018
…eaverryan) This PR was merged into the 1.0-dev branch. Discussion ---------- Don't use :contains in the functional test tpl `:contains` is a proprietary jQuery selector, and has been explicitly removed from the CSS 3 spec: https://stackoverflow.com/questions/4781141/why-doesnt-the-selector-h3nth-child1containsa-work/4781167#4781167 Then, it doesn't work with Panthère (it's actually supported by Selenium, but not by WebDriver). I propose to use Xpath instead. Commits ------- 7d580ea Using simpler selector 622b49c Don't use :contains in the functional test tpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:containsis a proprietary jQuery selector, and has been explicitly removed from the CSS 3 spec: https://stackoverflow.com/questions/4781141/why-doesnt-the-selector-h3nth-child1containsa-work/4781167#4781167Then, it doesn't work with Panthère (it's actually supported by Selenium, but not by WebDriver).
I propose to use Xpath instead.