Skip to content

Do not prefix Command Class Name by 'App' if the prefix is 'app:' #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javiereguiluz merged 2 commits into from
Jul 5, 2018
Merged

Do not prefix Command Class Name by 'App' if the prefix is 'app:' #205

javiereguiluz merged 2 commits into from
Jul 5, 2018

Conversation

@lyrixx
Copy link
Member

@lyrixx lyrixx commented Jun 13, 2018

No description provided.

@lyrixx
Copy link
Member Author

lyrixx commented Jul 4, 2018

Thanks @javiereguiluz

@javiereguiluz
Copy link
Member

javiereguiluz commented Jul 5, 2018

Thanks Grégoire.

@javiereguiluz javiereguiluz merged commit faa3923 into master Jul 5, 2018
javiereguiluz added a commit that referenced this pull request Jul 5, 2018
@javiereguiluz
minor #205 Do not prefix Command Class Name by 'App' if the prefix is…
020c048 
… 'app:' (lyrixx, javiereguiluz)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Do not prefix Command Class Name by 'App' if the prefix is 'app:'

Commits
-------

faa3923 Minor code refactor
4a013a2 Do not prefix Command Class Name by 'App' if the prefix is 'app:'
@lyrixx lyrixx deleted the cmd branch July 6, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lyrixx @javiereguiluz