Skip to content

Conversation

@jrushlow
Copy link
Collaborator

Unable to run make:entity tests that require api-platform as a dependency. API Platform v3.4 does not allow for api_platform.keep_legacy_inflector to be set, but it's automatically included in <3.4 recipe(s). No recipe exists yet for >=3.4.

Skipped Test Cases:

  • it_creates_a_new_class_and_api_resource
  • it_makes_new_entity_no_to_all_extras

Tests to be re-enabled once symfony/recipes#1339 is merged.


There are more complex ways to restrict these 2 test cases to run on =<3.3 - but this is the easiest path forward at the moment.

@jrushlow jrushlow added the Minor Minor Enhancement label Sep 25, 2024
@jrushlow jrushlow merged commit 3cf70d8 into symfony:main Sep 25, 2024
@jrushlow jrushlow deleted the ci/skip-api-test-tmp branch September 25, 2024 09:18
jrushlow added a commit to jrushlow/maker-bundle that referenced this pull request Sep 28, 2024
symfony/recipes#1339 is now merged - we dont need to skip these tests anymore.
alexislefebvre added a commit to alexislefebvre/symfony-maker-bundle that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Minor Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant