[make:listener] Match event name against active events class/id #1579
+124
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I like the idea and will indeed simplify such maker, and behavior can be duplicated on others as well I think |
jrushlow
requested changes
Jul 31, 2024
Collaborator
jrushlow
left a comment
jrushlow
left a comment
There was a problem hiding this comment.
Thank you for working on this @maelanleborgne - a couple of minor comments below...
Comment on lines
112
to
113
| $suggestionList = []; | ||
| foreach ($eventIdAndFQCNList as $eventSuggestion) { |
Collaborator
There was a problem hiding this comment.
Add spacing for readability between logic statements (e.g. if's) to be consistent with other code in the bundle.
Suggested change
| $suggestionList = []; | |
| foreach ($eventIdAndFQCNList as $eventSuggestion) { | |
| $suggestionList = []; | |
| foreach ($eventIdAndFQCNList as $eventSuggestion) { |
We need to do this for the other if statements below as well.
src/Maker/MakeListener.php
Outdated
| if (1 === \count($suggestionList)) { | ||
| $question = new ConfirmationQuestion(sprintf('<fg=green>Did you mean</> <fg=yellow>"%s"</> <fg=green>?</>', $suggestionList[0]), false); | ||
| $event = $io->askQuestion($question) ? $suggestionList[0] : $event; | ||
| } else { |
Collaborator
There was a problem hiding this comment.
We can eliminate this else condition by returning early inside the if conditional. Then just have the statements within the else called after the if.
maelanleborgne
force-pushed
the
feature/listener-class-match
branch
from
8fe0c1e to
86f6dd6
Compare
jrushlow
approved these changes
Aug 29, 2024
Collaborator
jrushlow
left a comment
jrushlow
left a comment
There was a problem hiding this comment.
Thank you @maelanleborgne
jrushlow
added
Status: Reviewed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1410
Description
The goal of this PR is to simplify the usage of the
make:listenercommand by adding the following features to the event input :Example
Matching on class short name :
Matching on class short name when multiple events match :
Typo detection :