[make:entity] add enum support #1534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicsapone
force-pushed
the
make-entity-enum
branch
from
a5966a3 to
aab771b
Compare
jrushlow
requested changes
May 6, 2024
Collaborator
jrushlow
left a comment
jrushlow
left a comment
There was a problem hiding this comment.
Howdy @loicsapone - Thank you for getting this going! I do have one change that we need to address before we can move forward with the review / merge.
Side note: this fixes #1440
Contributor
Author
|
@jrushlow I've pushed the new "enum" type under the "other" category |
jrushlow
approved these changes
May 19, 2024
Collaborator
jrushlow
left a comment
jrushlow
left a comment
There was a problem hiding this comment.
Look's good, let's run with it! Thank you @loicsapone
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
The purpose of this PR is to add support for enumerations when creating an entity.
Instead of introducing a new field type, I've opted to add a prompt to supplement a text field with the enumType option.
Edit by @jrushlow
fixes #1440 fixes #1233