Skip to content

[make:*] add docBlock return types for non-internal makers #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrushlow merged 1 commit into from
Apr 2, 2024
Merged

[make:*] add docBlock return types for non-internal makers #1499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Maker/MakeFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public static function getCommandDescription(): string
return 'Create a new class to load Doctrine fixtures';
}

/** @return void */
public function configureCommand(Command $command, InputConfiguration $inputConf)
{
$command
Expand All @@ -47,6 +48,7 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
;
}

/** @return void */
public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator)
{
$fixturesClassNameDetails = $generator->createClassNameDetails(
Expand Down Expand Up @@ -78,6 +80,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
]);
}

/** @return void */
public function configureDependencies(DependencyBuilder $dependencies)
{
$dependencies->addClassDependency(
Expand Down
4 changes: 3 additions & 1 deletion src/Maker/MakeMigration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
;
}

/** @return void */
public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator)
{
$options = ['doctrine:migrations:diff'];
Expand Down Expand Up @@ -145,7 +146,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
]);
}

private function noChangesMessage(ConsoleStyle $io)
private function noChangesMessage(ConsoleStyle $io): void
{
$io->warning([
'No database changes were detected.',
Expand All @@ -156,6 +157,7 @@ private function noChangesMessage(ConsoleStyle $io)
]);
}

/** @return void */
public function configureDependencies(DependencyBuilder $dependencies)
{
$dependencies->addClassDependency(
Expand Down
3 changes: 3 additions & 0 deletions src/Maker/MakeValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public static function getCommandDescription(): string
return 'Create a new validator and constraint class';
}

/** @return void */
public function configureCommand(Command $command, InputConfiguration $inputConf)
{
$command
Expand All @@ -45,6 +46,7 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
;
}

/** @return void */
public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator)
{
$validatorClassNameDetails = $generator->createClassNameDetails(
Expand Down Expand Up @@ -79,6 +81,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
]);
}

/** @return void */
public function configureDependencies(DependencyBuilder $dependencies)
{
$dependencies->addClassDependency(
Expand Down