Skip to content

Conversation

@madflow
Copy link

@madflow madflow commented Mar 15, 2024

jrushlow added a commit to jrushlow/maker-bundle that referenced this pull request Mar 16, 2024
@jrushlow jrushlow changed the title fix: add failing tests [make:entity] fix: add failing tests Mar 16, 2024
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test @madflow - the problem is in Generator and ultimately in how we validate a class against the autoloader. I've created a PR #1482 with a similar test case and I'm working on a fix that, hopefully, doesnt require reverting #1422.

We'll more than likely get this merged in about the same time I'm able to work out a fix in #1482

@jrushlow jrushlow added Status: Needs Work Additional work is needed Minor Minor Enhancement labels Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Minor Enhancement Status: Needs Work Additional work is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants