[make:registration-form] Removal of the createView() method, as it is no longer required to render the form
#1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
requested changes
Feb 20, 2024
Collaborator
jrushlow
left a comment
jrushlow
left a comment
There was a problem hiding this comment.
Awesome! One comment though...
...res/make-registration-form/tests/it_generates_registration_with_entity_and_authenticator.php
Show resolved
Hide resolved
jrushlow
added
Status: Waiting Feedback
jrushlow
changed the title
createView() method, as it is no longer required to render the formcreateView() method, as it is no longer required to render the form
jrushlow
approved these changes
Feb 20, 2024
Collaborator
jrushlow
left a comment
jrushlow
left a comment
There was a problem hiding this comment.
Thank you @mdoutreluingne!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1453