[make:*] improve support for ORM 3.x / DBAL 4.x #1439
Conversation
jrushlow
changed the title
jrushlow
changed the title
jrushlow
force-pushed
the
ci/handle-database-create
branch
from
2faf253 to
90a3123
Compare
| <!-- Overrides process timeout when step debugging --> | ||
| <!-- <env name="MAKER_PROCESS_TIMEOUT" value="null" /> --> |
There was a problem hiding this comment.
Allows for debugging Process::fromShellCommandLine() which sets the process $timeout to 60 seconds
| * | ||
| * @internal | ||
| */ | ||
| final class ClassProperty |
There was a problem hiding this comment.
We'll be able to do additional refactorings in CSM/Maker that will further utilize value object.. e.g. addProperty()
| env: | ||
| PHPUNIT_FLAGS: "-v" | ||
| SYMFONY_PHPUNIT_DIR: "$HOME/symfony-bridge/.phpunit" | ||
| MAKER_SKIP_MERCURE_TEST: 1 |
There was a problem hiding this comment.
ux-turbo uses Doctrine\Commom\Util\ClassUtils::class which no longer exists. As such, 2 MakeEntity tests fail that use Mercure. Keep this here && create an maker bundle issue to fix? Or live with (for now) the red x's on all of our tests?
There was a problem hiding this comment.
Keep this for now. Then we'll fix it in ux-turbo at some point.
jrushlow
changed the title
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
This looks like very detailed work & solid 🦾. If any details were missed, the tests should have caught them.
| env: | ||
| PHPUNIT_FLAGS: "-v" | ||
| SYMFONY_PHPUNIT_DIR: "$HOME/symfony-bridge/.phpunit" | ||
| MAKER_SKIP_MERCURE_TEST: 1 |
There was a problem hiding this comment.
Keep this for now. Then we'll fix it in ux-turbo at some point.
jrushlow
added
Status: Reviewed
2 participants
doctrine/ormversion to^2.15|^3doctrine/doctrine-bundleto^2.10FieldMapping,ManyToOneMapping, etc...)MAKER_PROCESS_TIMEOUTenv that can be set tonullor a float. This overrides the defaultProcess::timeoutvalue of60for shell commands in test. (Allows step debugging w/ XDebug)ux/turbousesDoctrine\Common\Util\ClassUtilswhich no longer exists. (Fails all of our tests) See comment in review.ORM\..\DisconnectedClassMetadataFactoryis removed inorm 3.0-> set theStaticReflectionService::classmanually when getting metadata for disconnected entities. (e.g. xml mapping) - Reference ClassMetadataInfo less and less doctrine/orm#9704