Skip to content

Conversation

@njutn95
Copy link
Contributor

@njutn95 njutn95 commented Feb 3, 2024

Fixes #1437

This PR removes the use of Types::ARRAY and Types::OBJECT as they were removed in Doctrine v4.0 (see doctrine/dbal@763b4ad).

@derrabus
Copy link
Member

derrabus commented Feb 5, 2024

What if someone still uses DBAL 3 and relies on those deprecated types?

@stof
Copy link
Member

stof commented Feb 5, 2024

I suggest putting the type name as a string for those instead of removing them entirely for those legacy types (as done for the uuid and ulid types)

@njutn95
Copy link
Contributor Author

njutn95 commented Feb 5, 2024

You're right! I've added backward compatibility. I just thought that adding the BC for something that has already been deprecated in the past is not really worth it in the maker bundle.

@weaverryan
Copy link
Member

Thanks @njutn95! We're working on the test failures - it looks like the started exploding with the new Doctrine releases 🤔

@weaverryan weaverryan merged commit 3e01cf2 into symfony:main Feb 5, 2024
@jrushlow jrushlow mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make:user ends with "Undefined constant Doctrine\DBAL\Types\Types::ARRAY" error

4 participants