Skip to content

make the MakerFileLinkFormatter compatible with Symfony 7 #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xabbuh merged 1 commit into from
Oct 30, 2023
Merged

make the MakerFileLinkFormatter compatible with Symfony 7 #1383

xabbuh merged 1 commit into from
Oct 30, 2023

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 23, 2023

fixes #1382

@xabbuh xabbuh mentioned this pull request Oct 23, 2023
Closed
weaverryan
weaverryan reviewed Oct 23, 2023
View reviewed changes
src/Util/MakerFileLinkFormatter.php
{
public function __construct(
private ?FileLinkFormatter $fileLinkFormatter = null,
private FileLinkFormatter|LegacyFileLinkFormatter|null $fileLinkFormatter = null,
Copy link
Member

@weaverryan weaverryan Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fail in Symfony 6.3 where FileLinkFormatter (the new one) does not exist? It seems to: https://github.com/symfony/maker-bundle/actions/runs/6610525836/job/17952630835?pr=1383#step:14:74

Do we need to remove the type until 6.3 support is dropped?

Copy link
Member Author

@xabbuh xabbuh Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be the issue. I am gonna take a deeper look into the failure.

Copy link
Member Author

@xabbuh xabbuh Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fixed

@tacman
Copy link
Contributor

tacman commented Oct 29, 2023

I'd love to use this bundle when testing Symfony 7, but all the make: commands are broken. Can this be at least pushed to the dev branch?

@jeremyFreeAgent
Copy link

jeremyFreeAgent commented Oct 30, 2023

Currently I sed this fix :

sed  -e "s/HttpKernel\\\Debug/ErrorHandler\\\ErrorRenderer/" vendor/symfony/maker-bundle/src/Util/MakerFileLinkFormatter.php

@tacman
Copy link
Contributor

tacman commented Oct 30, 2023

Thanks! I think that should be sed -i (not -e).

@xabbuh xabbuh merged commit 1d89c81 into symfony:main Oct 30, 2023
@xabbuh xabbuh deleted the issue-1382 branch October 30, 2023 09:59
@jeremyFreeAgent
Copy link

jeremyFreeAgent commented Oct 30, 2023

Thanks for the merge!

@antalaron antalaron mentioned this pull request Nov 3, 2023
Closed
@GromNaN GromNaN mentioned this pull request Nov 29, 2023
Closed
@derrabus
Copy link
Member

derrabus commented Nov 29, 2023

@weaverryan Can we please release this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weaverryan weaverryan weaverryan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Maker] Running make:command throw TypeError with FileLinkFormatter

5 participants

@xabbuh @tacman @jeremyFreeAgent @derrabus @weaverryan