Add relations to entity form generation #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelanleborgne
force-pushed
the
feature/add-relation-in-form-generation
branch
2 times, most recently
from
3ab1276 to
df282f4
Compare
weaverryan
reviewed
Oct 16, 2023
weaverryan
reviewed
Oct 17, 2023
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
This seems good to me - I'd love to see a test and also the multiple => true when needed
weaverryan
force-pushed
the
feature/add-relation-in-form-generation
branch
from
aeac1cc to
85e4306
Compare
Member
|
Thanks @maelanleborgne! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1372
When generating a form for an entity (through
make:formormake:crud), this feature adds an EntityType input for each compatible relations in the generate form.