Allow configuring the "extra.symfony.root-dir" of the Symfony app #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Dec 11, 2018
| @@ -97,7 +97,7 @@ public function copyFile(string $source, string $target, bool $overwrite = false | |||
| throw new LogicException(sprintf('File "%s" does not exist!', $source)); | |||
| } | |||
|
|
|||
| copy($source, $target); | |||
| file_put_contents($target, $this->options->expandTargetDir(file_get_contents($source))); | |||
There was a problem hiding this comment.
This replaces eg %CONFIG_DIR% in files copied from packages (same for recipes below).
Will allow replacing config/bootstrap.php by %CONFIG_DIR%/bootstrap.php in a few months when everyone will have moved to a more recent flex version.
Pierstoval
reviewed
Dec 11, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Dec 19, 2018
…mfony app (nicolas-grekas) This PR was merged into the 1.1-dev branch. Discussion ---------- Allow configuring the "extra.symfony.root-dir" of the Symfony app Fixes #243 and makes path management a bit more flexible. Commits ------- 186bee1 Allow configuring the "extra.symfony.root-dir" of the Symfony app
tgalopin
pushed a commit
to tgalopin/flex
that referenced
this pull request
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243
and makes path management a bit more flexible.