Skip to content

Fail CI if the repo is in a dirty state after building assets #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2019
Merged

Fail CI if the repo is in a dirty state after building assets #984

merged 1 commit into from
Jun 3, 2019

Conversation

bocharsky-bw
Copy link
Contributor

@bocharsky-bw bocharsky-bw commented Jun 2, 2019 •
edited
Loading

In order to prevent things fixed in #982 I think we can check for missing assets on TravisCI

Tests should pass after merging #982

@bocharsky-bw bocharsky-bw marked this pull request as ready for review June 2, 2019 19:55
@javiereguiluz
Copy link
Member

Very nice! I like this idea a lot. I'm going to change yarn build by yarn build production to be more explicitly.

@javiereguiluz javiereguiluz merged commit 1ae5bb1 into symfony:master Jun 3, 2019
javiereguiluz added a commit that referenced this pull request Jun 3, 2019
@javiereguiluz
feature #984 Fail CI if the repo is in a dirty state after building a…
4a1acec 
…ssets (bocharsky-bw)

This PR was merged into the master branch.

Discussion
----------

Fail CI if the repo is in a dirty state after building assets

In order to prevent things fixed in #982 I think we can check for missing assets on TravisCI

Tests should pass after merging #982

Commits
-------

1ae5bb1 Fail CI if the repo is in a dirty state after building assets
@bocharsky-bw bocharsky-bw deleted the patch-3 branch June 3, 2019 13:37
@bocharsky-bw
Copy link
Contributor Author

bocharsky-bw commented Jun 3, 2019 •
edited
Loading

@javiereguiluz not sure about yarn build production command, because it fails even locally for me:

yarn run v1.15.2
$ encore production --progress production
Running webpack ...

 94% after seal ERROR  Failed to compile with 1 errors                                                                                                          5:11:20 PM

 error

Entry module not found: Error: Can't resolve 'production' in '/Users/victor/www/symfony/demo'


Insufficient number of arguments or no entry found.
Alternatively, run 'webpack(-cli) --help' for usage info.

does it work for you locally?

@javiereguiluz
Copy link
Member

It should be yarn encore production (and yarn encore dev --watch) Sorry! This is being fixed in #990.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature FINISHED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bocharsky-bw @javiereguiluz