Rebuild assets and return back styles #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2019
|
I don't understand this PR:
So, I can't merge this ... and I can't reproduce this 🤔 Could you please double check what's going on here? Thanks. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 3, 2019
…ssets (bocharsky-bw) This PR was merged into the master branch. Discussion ---------- Fail CI if the repo is in a dirty state after building assets In order to prevent things fixed in #982 I think we can check for missing assets on TravisCI Tests should pass after merging #982 Commits ------- 1ae5bb1 Fail CI if the repo is in a dirty state after building assets
|
I've merged this using GitHub's button instead of Symfony's merging tool. It worked! |
|
Ah, you were faster than me :) P.S. Not sure what was the problem though, glad you were able to merge it this way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #980
Looks like assets were not rebuilt/committed on a PR that was merged to master that's why we lost all styles after installing Demo from scratch following the README
I just rebuilt the assets and committed changes here.