[pull] swiftwasm-release/5.3 from swift/release/5.3 #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
In XCode 12, ld64 got support for @files, in addition to the old -filelist mechanism. Response files allow passing all command-line arguments to the linker via a file, rather than just filenames, and is therefore preferred. Because of the way response-file support is currently implemented as part of the Tool class in Clang, this change requires an ugly backdoor function to access Args. A follow-up commit fixes this, but I've ordered this change first, for easier backportability. I've added no tests here, because unfortunately, there don't appear to be _any_ response-file emission automated tests, and I don't see an obvious way to add them. I've tested that this change works as expected locally. Differential Revision: https://reviews.llvm.org/D82777 (cherry picked from commit 381df16)
Clang Driver: Use Apple ld64's new @response-file support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )