Fix VS Code formatting inconsistencies #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
requested review from
adam-fowler,
0xTim and
award999
as code owners
plemarquand
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the VS Code settings for the project as it was not formatting certain files in the same way as CI expects. One of my recent PRs failed CI because VS Code wasn't formatting the
tsConfig.jsonproperly.I've opted to use the
.prettierignorefile to configure which files we want to lint rather than passing in specific files/directories to prettier in thepackage.json. This means that we can just update one file going forward if we want to do more formatting and VS Code will stay in sync with CI.