[6.3][DeclChecker] Skip contextualization of initializers associated with … #86097
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…property wrapped variables Fixes a double-contextualization that results in an assert because properties with property wrappers have the same initializer in two places - original property (which becomes computed) and backing storage property - that's where the initializer is copied. Contextualization of the fully type-checked initializer should happen as part of backing storage property processing by the declaration checker. Resolves: rdar://163562182 (cherry picked from commit 5e815b9)
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…property wrapped variables
Explanation:
Fixes a double-contextualization that results in an assert because properties with property wrappers have the same initializer in two places - original property (which becomes computed) and backing storage property - that's where the initializer is copied.
Contextualization of the fully type-checked initializer should happen as part of backing storage property processing by the declaration checker.
Resolves: rdar://163562182
Main branch PR: [DeclChecker] Skip contextualization of initializers associated with … #86024
Risk: Low. Affects only specific situations with property wrappers with extra arguments that require non-exhaustive rethrows checking.
Reviewed By: @hborla
Testing: Added new test-cases to the suite.
(cherry picked from commit 5e815b9)