[Sema]: ban the use of 'nonisolated' on actor declarations #85185
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combination doesn't make sense, so don't allow it.
jamieQ
requested review from
hborla,
ktoso,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
ktoso
approved these changes
Oct 29, 2025
|
Heh "nonisolated actor" that's pretty hilarious |
jamieQ
commented
Oct 29, 2025
ktoso
approved these changes
Oct 29, 2025
|
@swift-ci please test source compatibility |
jamieQ
commented
Oct 29, 2025
jamieQ
changed the title
|
I searched around some more, let's try to make it a hard error right away. |
ktoso
approved these changes
Oct 30, 2025
We've searched and can't find any usage of this in the wild, so hope we can get away with banning this outright.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
Just in case. |
|
Ok yeah let's do that with the actual error mode, thanks Pavel 👍 |
jamieQ
changed the title
|
looks like the source compat suite had the same spurious failures as the first try |
|
Resolves rdar://163558599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combination doesn't make sense, so don't allow it.
Resolves: #85174