[cxx-interop] Implicitly defined copy constructors #84646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susmonteiro
requested review from
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
hnrklssn,
ian-twilightcoder,
j-hui and
rjmccall
as code owners
susmonteiro
force-pushed
the
susmonteiro/implicit-copy-constructors
branch
from
4b41375 to
73d4c7c
Compare
Contributor
Author
|
@swift-ci please smoke test |
Xazax-hun
reviewed
Oct 2, 2025
susmonteiro
force-pushed
the
susmonteiro/implicit-copy-constructors
branch
from
73d4c7c to
266be88
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
|
@swift-ci please smoke test |
susmonteiro
force-pushed
the
susmonteiro/implicit-copy-constructors
branch
from
266be88 to
b20df60
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please build toolchain macos |
Contributor
Author
|
@swift-ci please smoke test macos |
Contributor
Author
|
@swift-ci please smoke test linux |
susmonteiro
force-pushed
the
susmonteiro/implicit-copy-constructors
branch
from
b20df60 to
5eea81e
Compare
Contributor
Author
|
@swift-ci please smoke test |
susmonteiro
force-pushed
the
susmonteiro/implicit-copy-constructors
branch
from
5eea81e to
6facdeb
Compare
susmonteiro
force-pushed
the
susmonteiro/implicit-copy-constructors
branch
from
6facdeb to
1c5bbe0
Compare
Contributor
Author
|
@swift-ci please smoke test |
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a C++ type doesn't have a user provided copy constructor, Clang will declare one implicitly, unless one of its fields is not copy-constructible. Clang assumes that any
std::vectoris always copy-constructible, including astd::vectorof a non-copy constructible type. So, let's use theCxxValueSemanticsimplemented in #84340 to figure out if we should ask Clang to define the copy constructor for such types.This also includes types that have a defaulted, user-provided copy constructor.
rdar://151870709