ConstantCapturePropagation: don't propagate keypaths with multiple uses in non-OSSA #84564
+104
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
…es in non-OSSA We cannot do this because we don't know where to insert the compensating release after the propagated `partial_apply`. A required `strong_retain` may have been moved over the `partial_apply`. Then we would release the keypath too early. Fixes a mis-compile rdar://161321614
eeckstein
force-pushed
the
fix-constant-capture-propagation
branch
from
5169a3f to
273874c
Compare
Contributor
Author
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot do this because we don't know where to insert the compensating release after the propagated
partial_apply.A required
strong_retainmay have been moved over thepartial_apply.Then we would release the keypath too early.
Fixes a mis-compile
rdar://161321614