-
Notifications
You must be signed in to change notification settings - Fork 10.6k
GettingStarted.md: avoid preinstalling CMake #83063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GettingStarted.md: avoid preinstalling CMake #83063
Conversation
We're seeing multiple build failures with CMake 4.0: e.g. SwiftPM bootstrapping issues on macOS. `build-script` will always build a fixed version of CMake that's known to work if preinstalled one is not found. Let's reduce the chances for confusion by not recommending preinstalled CMake in `GettingStarted.md`.
|
@swift-ci smoke test |
| 1. Install [Ninja][] and [Sccache][]: | ||
| - Via [Homebrew][] (recommended): | ||
| ```sh | ||
| brew install cmake ninja sccache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comment, can we just pin it instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto, the answer is "no" unfortunately
|
@swift-ci smoke test macos |
bnbarham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to get this working, but better to not be confusing for now 👍
|
I ran into an issue today. |
Which exact commit are you trying to build and on which OS? What's the exact |
|
I assume you're building on macOS? That's fixed in #83296, you'll have to re-run |
|
Also updating |
|
Ah thanks for all the great comments! Yeah I was at the tip of main today so commit |
|
@MaxDesiatov I do keep running into an issue that might be related to cmake. I tried setting the CC variable but it doesn't seem to be picked up since the already set path probably has presedence and indeed doesn't contain clang. I ran the following invocation of build-script: Not sure if this was part of the issues with CMake? |
|
Can you ensure that the version CMake you're running is the one built by |
|
I no longer have cmake installed locally so it should be, but also yeah it mentions I'm not sure which product it is? How do I identify that specifically? Could that be bootstrap or maybe swift-system? Please let me know what I can provide you with :) |
|
@MaxDesiatov Here's a larger part of the output I'm seeing hope that helps: So I feel it's trying to build swift-system in order to build swiftpm? |
|
Does |
|
Ah yeah that was missing from my invocation. Will run it with that now, thanks! |
|
That worked! Thanks. The full invocation that worked for me was: |
We're seeing multiple build failures with CMake 4.0: e.g. SwiftPM bootstrapping issues on macOS.
build-scriptwill always build a fixed version of CMake that's known to work if preinstalled one is not found. Let's reduce the chances for confusion by not recommending preinstalled CMake inGettingStarted.md.