[AutoDiff] Initial support for differentiation of throwing functions #82653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asl
requested review from
a team,
hborla,
slavapestov,
xedin,
eeckstein and
jckarter
as code owners
|
Tagging @JaapWijnen @kovdan01 |
|
@swift-ci please test |
This was
linked to
issues
Jun 30, 2025
Open
asl
changed the title
|
@swift-ci please test |
|
Windows fails in unrelated @swift-ci please test windows platform |
kovdan01
reviewed
Jul 7, 2025
| assert(inserted && "should have unique adjoint for try_apply"); | ||
| break; | ||
| } | ||
| case SILValueCategory::Address: { |
There was a problem hiding this comment.
With existing tests, we never fall into this case. It's probably worth covering it with tests.
There was a problem hiding this comment.
Yes, it seems we'd need something like object value with non-loadable tangent.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support for differentiation of functions that may produce
Errorresult. Essentially we wrap the pullback intoOptionaland emit a diamond-shape control flow pattern depending on whether the pullback value is available or not. VJP emission was modified to accommodate for this. In addition to this, some additional tricks are requires astry_applyresult is not available in the instruction parent block, it is available in normal successor basic block.As a result we can now:
try_applyresult (that would be produced fromdo ... try .. catchconstructions)try_applywhen error result is unreachable (usuallytry!and similar source code constructs)@derivative(of:)attribute, so we can register custom derivatives for functions producing error resultOptional.??operator (note that support here is not yet complete as we cannot differentiate through autoclosures, sox ?? yworks only ifyis not active, e.g. a constant value).Some fixes here and there