-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Enable MainActor
in embedded concurrency, add ExecutorImpl.cpp
#82331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok I think
@swift-ci smoke test |
@swift-ci build toolchain |
@swift-ci smoke test macos |
@al45tair could you take a look here? |
My concern with this is that there might be people using Embedded Swift with the existing CooperativeGlobalExecutor from the static archive, and adding Also, you'll need to update the copy of the Concurrency |
@swift-ci smoke test |
`ExecutorImpl.cpp` should be moved from `SWIFT_RUNTIME_CONCURRENCY_NONEMBEDDED_C_SOURCES` to `SWIFT_RUNTIME_CONCURRENCY_C_SOURCES`. This way we can also include `ExecutorImpl.swift` and use `PlatformExecutorCooperative.swift` in embedded concurrency for WASI.
1bd782a
to
959e75b
Compare
I've updated the changes to be isolated to Wasm only, where it is expected. No other users should be impacted.
|
a4ca548
to
9cdfc28
Compare
@swift-ci smoke test |
@swift-ci test windows |
1 similar comment
@swift-ci test windows |
ExecutorImpl.cpp
should be moved fromSWIFT_RUNTIME_CONCURRENCY_NONEMBEDDED_C_SOURCES
toSWIFT_RUNTIME_CONCURRENCY_C_SOURCES
. This way we can also includeExecutorImpl.swift
and usePlatformExecutorCooperative.swift
in embedded concurrency for WASI.