[cxx-interop] Fix compilation failure in rebranch #81898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar and
susmonteiro
as code owners
egorzhdan
approved these changes
Jun 2, 2025
It looks like in the latest version of clang needs parameters to be named for the lifetimebound attribute to be applicable. rdar://151918181
Xazax-hun
force-pushed
the
gaborh/rebranch-test-fix
branch
from
6ca98dc to
64babf5
Compare
|
@swift-ci please smoke test |
AnthonyLatsis
approved these changes
Jun 2, 2025
AnthonyLatsis
referenced
this pull request
Jul 9, 2025
The `stable/20250601` Clang apparently wants an attributed parameter to
have a name, and that the attributes follow the name:
```
/Users/alatsis/Desktop/rebranch/swift/test/Interop/C/swiftify-import/Inputs/counted-by-lifetimebound.h:7:76: error: 'lifetimebound' attribute only applies to parameters and implicit object parameters
int * __counted_by(len) simple(int len, int len2, int * __counted_by(len2) __lifetimebound p);
^
/Users/alatsis/Desktop/rebranch/swift/test/Interop/C/swiftify-import/Inputs/counted-by-lifetimebound.h:5:40: note: expanded from macro '__lifetimebound'
^
```
Also humor the compiler here:
```
3 | #define __counted_by(x) __attribute__((__counted_by__(x)))
| `- note: expanded from macro '__counted_by'
4 | #define __counted_by_or_null(x) __attribute__((__counted_by_or_null__(x)))
5 | #define __lifetimebound __attribute__((lifetimebound))
:
22 | int * __counted_by(len) noncountedLifetime(int len, int * p __lifetimebound);
23 |
24 | int * __counted_by(13) _Nullable constant(int * _Nullable p __counted_by(13) __lifetimebound);
| `- error: combining '__counted_by' with non-zero count (which cannot be null) and '_Nullable'; did you mean '__counted_by_or_null' instead?
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like in the latest version of clang, it needs parameters to be named for the lifetimebound attribute to be applicable.
rdar://151918181