[test] lit.cfg: Wrap all substitutions with capture group refs in SubstituteCaptures
#81764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
force-pushed
the
rebranch-lit
branch
from
40ea556 to
ca5fe3c
Compare
AnthonyLatsis
changed the title
SubstituteCaptures whenever the replacement has…SubstituteCaptures
|
@swift-ci please test |
…bstituteCaptures` Since llvm/llvm-project#103042, backslashes in substitutions are consistently escaped on all platforms before feeding the substitutions to the regex engine. Make sure all substitutions containing capture group references are wrapped in `SubstituteCaptures` to suppress this behavior once main is rebranched.
AnthonyLatsis
force-pushed
the
rebranch-lit
branch
from
ca5fe3c to
402ace5
Compare
|
@swift-ci please test |
bnbarham
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since llvm/llvm-project#103042, backslashes in substitutions are consistently escaped on all platforms before feeding the substitutions to the regex engine. Make sure all substitutions containing capture group references are wrapped in
SubstituteCapturesto suppress this behavior once main is rebranched.