[Distributed] Reproducer for generics and library evolution mode #80588
Conversation
ktoso
force-pushed
the
wip-regression-test-for-b-da-bad-access
branch
2 times, most recently
from
e1ca212 to
4fcbfbe
Compare
…ust work This corrects how we were dealing with dispatch thunks -- mostly be removing a lot of special casing we did but doesn't seem necessary and instead we correct and emit all the necessary information int TBD. This builds on swiftlang#74935 by further refining how we fixed that issue, and adds more regression tests. It also removes a load of special casing of distributed thunks in library evolution mode, which is great. Resolves and adds regression test for for rdar://145292018 This is also a more proper fix to the previously resolved but in a not-great-way which caused other issues: - resolves rdar://128284016 - resolves rdar://128310903
ktoso
force-pushed
the
wip-regression-test-for-b-da-bad-access
branch
from
4fcbfbe to
957a95b
Compare
|
Figured out a solution and even fixed other TBD issues along the way, and past TBD issues in a cleaner way. Will want to verify this in a project as well to make sure we don't break anyone with this but it looks solid -- way less special casing! |
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
@swift-ci please build toolchain macOS |
|
@swift-ci please test source compatibility |
test/Distributed/Runtime/distributed_actor_library_evolution_da_protocol_use.swift
Show resolved
Hide resolved
test/Distributed/Runtime/distributed_actor_library_evolution_da_protocol_use.swift
Outdated
Show resolved
Hide resolved
|
Hmm, build issue on simulator run, let me restrict this to macos and linux
|
|
@swift-ci please test |
This corrects how we were dealing with dispatch thunks -- mostly be
removing a lot of special casing we did but doesn't seem necessary and
instead we correct and emit all the necessary information int TBD.
This builds on #74935 by further refining how we fixed that issue, and adds more regression tests. It also removes a load of special casing of distributed thunks in library evolution mode, which is great.
Resolves and adds regression test for for rdar://145292018
This is also a more proper fix to the previously resolved but in a not-great-way which caused other issues: