Fix field count in emitted reflection data #78981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR swiftlang#78467 omitted certain fields from the FieldDescriptor list, but did not update the count of fields that's emitted just before that list. Update the count so it matches the number of field descriptors we actually emit. Resolves rdar://143402921
|
@swift-ci Please test |
egorzhdan
approved these changes
Jan 28, 2025
DougGregor
approved these changes
Jan 28, 2025
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
Jan 30, 2025
**Without swiftlang#78981**: This test triggers "Reflection section too small to contain next record" errors, indicating that the field information is broken. **With swiftlang#78981**: This test runs to completion without triggering the error message above.
Merged
tbkka
added a commit
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #78467 omitted certain fields from the FieldDescriptor list,
but did not update the count of fields that's emitted
just before that list. That PR was merged to release/6.1 in #78607.
This updates the count so it matches the number of field descriptors
we actually emit.
Reviewed by: @egorzhdan @mikeash
Impact: Fixes RemoteMirror field reflection, which is used by tools such as
leaks,heap, andlldb.Risk: Low, fixes a broken count in metadata emitted for certain imported C++ types.
Original PR: #78961
Resolves rdar://143763116
EDITED: #79038 has the test that verifies the correctness of this fix.