[cxx-interop] Skip type metadata for C++ types that are only used in private C++ fields #78467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Jan 7, 2025
egorzhdan
force-pushed
the
egorzhdan/sizeof-incomplete
branch
from
6542187 to
a0d24fb
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
LGTM, but please add a test case; it should be straightforward to test that we don't emit field metadata for these fields. Also, is the right condition that it's |
|
Thanks @rjmccall, I'll add a test before merging this.
We're checking the access level of the imported Swift decl, and C++ |
egorzhdan
force-pushed
the
egorzhdan/sizeof-incomplete
branch
from
a0d24fb to
b31a282
Compare
|
@swift-ci please smoke test |
…private C++ fields This fixes compiler errors for C++ types that use pimpl idiom: ``` invalid application of 'sizeof' to an incomplete type ``` rdar://141960396
egorzhdan
force-pushed
the
egorzhdan/sizeof-incomplete
branch
from
b31a282 to
738c8fb
Compare
|
@swift-ci please smoke test |
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
Jan 27, 2025
PR swiftlang#78467 omitted certain fields from the FieldDescriptor list, but did not update the count of fields that's emitted just before that list. Update the count so it matches the number of field descriptors we actually emit. Resolves rdar://143402921
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
Jan 28, 2025
PR swiftlang#78467 omitted certain fields from the FieldDescriptor list, but did not update the count of fields that's emitted just before that list. Update the count so it matches the number of field descriptors we actually emit. Resolves rdar://143402921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compiler errors for C++ types that use pimpl idiom:
rdar://141960396