Skip to content

[AutoDiff] Delete wrong FIXMEs (TF-284) from tests #78663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[AutoDiff] Delete wrong FIXMEs (TF-284) from tests #78663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/AutoDiff/Sema/differentiable_attr_type_checking.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,15 +290,13 @@ public struct PublicDiffAttrConformance: ProtocolRequirements {
var x: Float
var y: Float

// FIXME(TF-284): Fix unexpected diagnostic.
// expected-note @+2 {{candidate is missing explicit '@differentiable(reverse)' attribute to satisfy requirement}} {{10-10=@differentiable(reverse) }}
// expected-note @+1 {{candidate has non-matching type '(x: Float, y: Float)'}}
public init(x: Float, y: Float) {
self.x = x
self.y = y
}

// FIXME(TF-284): Fix unexpected diagnostic.
// expected-note @+2 {{candidate is missing explicit '@differentiable(reverse)' attribute to satisfy requirement}} {{10-10=@differentiable(reverse) }}
// expected-note @+1 {{candidate has non-matching type '(x: Float, y: Int)'}}
public init(x: Float, y: Int) {
Expand Down