runtime: address a declaration FIXME #78141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test Windows platform |
3 similar comments
|
@swift-ci please test Windows platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Windows platform |
Adjust the declarations to match the definitions and then remove the conditional declaration which was marked with a FIXME. This allows building the runtime without warnings in the new Runtimes build.
compnerd
force-pushed
the
declarations
branch
from
ec90c55 to
b1b8b46
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
We were getting some meaningful type-matching checking here, so can we at least use a |
|
Ugh, GitHub didn't show the comment until after I merged. I'm not sure which type matching you are referring to, but I'm happy to work that into a subsequent change to get that restored. |
|
Declaring an |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Jan 25, 2025
This addresses some feedback on swiftlang#78141 as per @rjmccall. Ensure that the runtime functions match the expected signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the declarations to match the definitions and then remove the conditional declaration which was marked with a FIXME. This allows building the runtime without warnings in the new Runtimes build.