Skip to content

Conversation

hjyamauchi
Copy link
Contributor

Update the pinned toolchain for Windows and enable SwiftCompilerSoures for Win/ARM64

Resolves #74866

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding @shahmishal and @DougGregor as this is going to change the bootstrapping toolchain. The changes themselves LGTM.

Please wait for signoff from @shahmishal before merging.

@compnerd compnerd requested a review from etcwilde December 10, 2024 18:14
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, LGTM!

@shahmishal
Copy link
Member

shahmishal commented Dec 12, 2024

Lets update this to Swift 6.0.3, just released swiftlang/swift-org-website#860

@hjyamauchi
Copy link
Contributor Author

TY! Updated to use the 6.0.3 build and locally tested which was good. @shahmishal Can you take another look?

@hjyamauchi
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hjyamauchi hjyamauchi merged commit 3f5a6f3 into swiftlang:main Dec 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SwiftCompilerSources doesn't work on Windows ARM64
5 participants