[cxx-interop] Add flag to assume C++ types are resilient #76907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
DougGregor,
egorzhdan,
hborla,
hyp,
slavapestov,
xedin and
zoecarver
as code owners
Contributor
Author
|
@swift-ci please smoke test |
include/swift/Basic/Features.def
Outdated
Contributor
There was a problem hiding this comment.
I think it is better not to use experimental feature since this is a flag to opt out of the error and not really a feature. Think it would better to have a flag that reads like allow-cxx-types-in-swift-interface
Member
There was a problem hiding this comment.
Personally, I prefer the experimental feature approach because they are easier to add and remove. If you add flags, you have to update the drivers and frontend, and possibly leave them in forever. Experimental features are more self-contained.
Currently, C++ types cannot appear in resilient interfaces. There are some cases where this is overly restrictive. We plan to improve the logic to detect what types should not appear on resilient moduel boundaries. In the meantime, this PR introduces a flag to disable these errors. Users relying on this flag are on their own, this should only be a temporary workaround until we land further improvements to this diagnostic. rdar://137457118
Xazax-hun
force-pushed
the
gaborh/assume-resilient-cxx-types
branch
from
0428799 to
cf3b333
Compare
Contributor
Author
|
@swift-ci please smoke test |
DougGregor
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, C++ types cannot appear in resilient interfaces. There are some cases where this is overly restrictive. We plan to improve the logic to detect what types should not appear on resilient moduel boundaries. In the meantime, this PR introduces a flag to disable these errors. Users relying on this flag are on their own, this should only be a temporary workaround until we land further improvements to this diagnostic.
rdar://137457118