Skip to content

MoveOnlyWrappedTypeEliminator: handle open_existential_box instructions #76715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024
Merged

MoveOnlyWrappedTypeEliminator: handle open_existential_box instructions #76715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/SILOptimizer/Mandatory/MoveOnlyWrappedTypeEliminator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ struct SILMoveOnlyWrappedTypeEliminatorVisitor
NO_UPDATE_NEEDED(Object)
NO_UPDATE_NEEDED(OpenExistentialRef)
NO_UPDATE_NEEDED(OpenExistentialAddr)
NO_UPDATE_NEEDED(OpenExistentialBox)
NO_UPDATE_NEEDED(ConvertFunction)
NO_UPDATE_NEEDED(RefToBridgeObject)
NO_UPDATE_NEEDED(BridgeObjectToRef)
Expand Down
14 changes: 12 additions & 2 deletions test/SILOptimizer/moveonly_type_eliminator.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
sil_stage raw

import Builtin
import Swift

//////////////////
// Declarations //
Expand Down Expand Up @@ -38,8 +39,6 @@ struct KlassPair {

sil @use_klass : $@convention(thin) (@guaranteed Klass) -> ()

protocol Error {}

///////////
// Tests //
///////////
Expand Down Expand Up @@ -616,6 +615,17 @@ bb0(%x : @guaranteed $any Error):
return %em : $@thick any Error.Type
}

// CHECK-LABEL: sil [ossa] @existential_box :
// CHECK: %1 = open_existential_box %0 : $any Error
// CHECK-LABEL: } // end sil function 'existential_box'
sil [ossa] @existential_box : $@convention(thin) (@guaranteed any Error) -> () {
bb0(%x : @guaranteed $any Error):
%y = copyable_to_moveonlywrapper [guaranteed] %x : $any Error
%o = open_existential_box %y : $@moveOnly (any Error) to $*@opened("01234567-89AB-CDEF-0123-000000000000", Error) Self
%r = tuple ()
return %r : $()
}

// CHECK-LABEL: sil [ossa] @builtin_tsanInoutAccess : {{.*}} {
// CHECK: builtin "tsanInoutAccess"
// CHECK-LABEL: } // end sil function 'builtin_tsanInoutAccess'
Expand Down