Extend internal _mangledTypeName() function to take non-copyable types.
#76041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
tbkka
approved these changes
Aug 22, 2024
|
Hmmm.... Test "demangleToMetadata" crashed on Linux. |
mikeash
approved these changes
Aug 22, 2024
|
@mikeash we have a lovely ABI test that tracks changes to stdlib symbols now, so that will fail if the symbol does change |
Azoy
approved these changes
Aug 22, 2024
Not yet! |
I believe this is a known compiler bug that's filed under another radar right now. This change may be blocked on that fix. |
|
@swift-ci test |
al45tair
approved these changes
Sep 11, 2024
…pes. `_mangledTypeName()` returns the Swift-mangled typename of a given type. This PR extends it to take non-copyable types as well. Resolves rdar://134278607.
grynspan
force-pushed
the
jgrynspan/134278607-mangledtypename-noncopyable
branch
from
0f1c02c to
6390152
Compare
|
@swift-ci test |
grynspan
deleted the
jgrynspan/134278607-mangledtypename-noncopyable
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_mangledTypeName()returns the Swift-mangled typename of a given type. This PR extends it to take non-copyable types as well.Related to our use case in Swift Testing, but not to the PR directly: #69146 #69147 #71112
Resolves rdar://134278607.