Link swift-ide-test against the new (early)swift-driver and exercise its getSingleFrontendInvocationFromDriverArguments C API
#75840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
NewDriverTooling
branch
3 times, most recently
from
f9b24d1 to
28a7f4f
Compare
artemcm
force-pushed
the
NewDriverTooling
branch
5 times, most recently
from
a76378a to
2bceadb
Compare
artemcm
changed the title
swift-ide-test against earlyswiftdriver and using its tooling libraryswift-ide-test against the new (early)swift-driver and exercise its getSingleFrontendInvocationFromDriverArguments C API
1 similar comment
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
artemcm
force-pushed
the
NewDriverTooling
branch
from
2bceadb to
db93ed7
Compare
|
@swift-ci test |
artemcm
force-pushed
the
NewDriverTooling
branch
from
db93ed7 to
400e9eb
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
artemcm
force-pushed
the
NewDriverTooling
branch
from
400e9eb to
10b66da
Compare
|
@swift-ci test |
…e its 'getSingleFrontendInvocationFromDriverArguments' API This lays the groundwork for what it takes to start using the new driver's C API from compiler products such as SourceKit
…id conflict with the new driver's corresponding entry
…tionFromDriverArgumentsV3` This is the most recent version of the API.
To function properly in "in-process" mode `swift-driver` requires all swift scanner symbols to be present in the binary to be discoverable by dlsym.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
bnbarham
reviewed
Jul 22, 2025
Comment on lines
+17
to
+19
| set(SwiftDriver_DIR | ||
| "${CMAKE_BINARY_DIR}/../earlyswiftdriver-${SWIFT_HOST_VARIANT}-${SWIFT_HOST_VARIANT_ARCH}/${driver_package_configuration_dir}/cmake/modules/") | ||
| set(TSC_DIR "${CMAKE_BINARY_DIR}/../earlyswiftdriver-${SWIFT_HOST_VARIANT}-${SWIFT_HOST_VARIANT_ARCH}/${driver_package_configuration_dir}/dependencies/swift-tools-support-core/cmake/modules/") |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, FetchContent or find_package should be what we use here instead of hard-coding these paths.
There was a problem hiding this comment.
Well technically we are doing a find_package, just setting SwiftDriver_DIR beforehand 😅. We currently set SWIFT_EARLY_SWIFT_DRIVER_BUILD, I'm not entirely clear why we're not just setting SwiftDriver_DIR though?
Comment on lines
+33
to
+40
| set_property( | ||
| TARGET swift-ide-test | ||
| APPEND PROPERTY INSTALL_RPATH "${CMAKE_BINARY_DIR}/../earlyswiftdriver-${SWIFT_HOST_VARIANT}-${SWIFT_HOST_VARIANT_ARCH}/${driver_package_configuration_dir}/lib/" | ||
| ) | ||
| set_property( | ||
| TARGET swift-ide-test | ||
| APPEND PROPERTY INSTALL_RPATH "${CMAKE_BINARY_DIR}/../earlyswiftdriver-${SWIFT_HOST_VARIANT}-${SWIFT_HOST_VARIANT_ARCH}/${driver_package_configuration_dir}/dependencies/swift-tools-support-core/lib/" | ||
| ) |
There was a problem hiding this comment.
Definitely don't want an absolute INSTALL_RPATH. I would have also thought that this isn't needed regardless - the lib to be in the same place as swift-syntax, which is already on the rpath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays the groundwork for what it takes to start using the new driver's C API from compiler products such as SourceKit
Using: swiftlang/swift-driver#1679