Optimizer: enable the DeinitDevirtualizer pass #75805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci benchmark |
Azoy
reviewed
Aug 9, 2024
atrick
approved these changes
Aug 11, 2024
… arguments It's not safe to insert a compensating release_value at the call site. This release_value calls the deinit which might have been already de-virtualized in the callee.
…estroyed value can't be de-virtualized This can happen if the destroyed type is resilient. Fixes a verifier crash.
It was disabled so far to not hide bugs in the deinit code generation. Now hopefully deinit code generation is stable enough to enable the pass.
eeckstein
force-pushed
the
enable-deinit-devirtualization
branch
from
5c0689c to
1dab294
Compare
|
@swift-ci test |
|
@swift-ci benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was disabled so far to not hide bugs in the deinit code generation. Now hopefully deinit code generation is stable enough to enable the pass.
Also fix a bug some bugs which showed up after enabling the pass.
E.g. don't convert non-copyable owned -> guaranteed arguments in FunctionSignatureOpts: It's not safe to insert a compensating release_value at the call site. This release_value calls the deinit which might have been already de-virtualized in the callee.