Skip to content

[Concurrency] Don't warn about re-stating inherited unavailable conformances to Sendable. #75359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[Concurrency] Don't warn about re-stating inherited unavailable conformances to Sendable. #75359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/Sema/TypeCheckConcurrency.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6195,7 +6195,11 @@ bool swift::checkSendableConformance(
return false;

// If this is an always-unavailable conformance, there's nothing to check.
if (auto ext = dyn_cast<ExtensionDecl>(conformanceDC)) {
// We always use the root conformance for this check, because inherited
// conformances need to walk back to the original declaration for the
// superclass conformance to find an unavailable attribute.
if (auto ext = dyn_cast<ExtensionDecl>(
conformance->getRootConformance()->getDeclContext())) {
if (AvailableAttr::isUnavailable(ext))
return false;
}
Expand Down
8 changes: 8 additions & 0 deletions test/Concurrency/concurrent_value_checking.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,14 @@ final class C7<T>: Sendable { }

class C9: Sendable { } // expected-warning{{non-final class 'C9' cannot conform to 'Sendable'; use '@unchecked Sendable'}}

@available(*, unavailable)
extension HasUnavailableSendable : @unchecked Sendable { }

class HasUnavailableSendable {
}

class NoRestated: HasUnavailableSendable {} // okay

@globalActor
struct SomeActor {
static let shared = A1()
Expand Down